Small Refactoring towards Stability #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Open

SpyrosMouselinos wants to merge 1 commit into gdmarmerola:master from SpyrosMouselinos:StabilityFix

SpyrosMouselinos commented Jun 7, 2021

Notes:

Added CG instead of L-BFGS-B.

No constraints are used so there is no need to use it.
On the other hand CG has convergence gurantees.

Added intercept support in the OnlineRegression method since the beta_0 variable was unused.
Changed the np.sum operation to np.mean.

Sum may work in small buffer sizes but can easily lead to instability, especially when including the intercept
Mean is more numerically stable since it reduces the overall magnitude of the minimization process


          Added CG instead of L-BFGS-B which is a constraint optimization algor…

8dd0c46

…ithm. Added intercept support

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet